in partnership with mediatemple

Ticket #893 (closed enhancement: fixed)

Opened 2 months ago

Last modified 2 months ago

Hash.toQueryString handles objects in hashes wrong

Reported by: zedix Owned by: digitarald
Type: enhancement Priority: minor
Milestone: Mootools version 1.3 Component: Core
Keywords: toquerystring Cc:

Description

In addition to the ticket #828 (fixed in r1479), I would suggest to implement the following spec to enhance Hash.toQueryString:

var myHash3 = new Hash({type:'cart', fruits: {apple:'red', lemon:'yellow'}}); 
value_of(myHash3.toQueryString()).should_be('type=cart&fruits[apple]=red&fruits[lemon]=yellow'); 

Fell free to close this ticket if you think this should be handle trough an Hash.implement extension only.

Change History

Changed 2 months ago by digitarald

  • owner set to digitarald
  • milestone changed from Mootools version 1.2 to Mootools version 1.3

That's why I called my implementation a rudimental implementation, it only solves the array problem. Its also in review status and eventually moved to 1.3. We can add a recursive solution for 1.3, I had the code already in my branch.

Changed 2 months ago by kamicane

  • status changed from new to closed
  • resolution set to invalid

implemented in [1483]

Changed 2 months ago by kamicane

  • status changed from closed to reopened
  • resolution deleted

Changed 2 months ago by kamicane

  • status changed from reopened to closed
  • resolution set to fixed

whops sorry, I meant fixed.

Note: See TracTickets for help on using tickets.