Ticket #421 (new enhancement)
Fx.Elements with array support
| Reported by: | JanK | Owned by: | |
|---|---|---|---|
| Type: | enhancement | Priority: | minor |
| Milestone: | Mootools version 1.3 | Component: | Core |
| Keywords: | Cc: |
Description
In many cases you want to change all elements of Fx.Elements and its ugly to pass an object like {'0': {}, '1': {}} because an Array like [{}, {}] fits better in this case. This diff adds the array support:
Index: /Users/jan/webdev/moodev/mootools/trunk/Effects/Fx.Elements.js
===================================================================
--- /Users/jan/webdev/moodev/mootools/trunk/Effects/Fx.Elements.js (revision 855)
+++ /Users/jan/webdev/moodev/mootools/trunk/Effects/Fx.Elements.js (working copy)
@@ -33,12 +33,12 @@
},
set: function(to){
+ this.css = {};
var parsed = {};
- this.css = {};
- for (var i in to){
+ $each(to, function(prop, i){
var iTo = to[i], iParsed = parsed[i] = {};
for (var p in iTo) iParsed[p] = Fx.CSS.set(iTo[p]);
- }
+ });
return this.parent(parsed);
},
@@ -67,14 +67,14 @@
this.now = {};
this.css = {};
var from = {}, to = {};
- for (var i in obj){
- var iProps = obj[i], iFrom = from[i] = {}, iTo = to[i] = {};
- for (var p in iProps){
- var parsed = Fx.CSS.prepare(this.elements[i], p, iProps[p]);
- iFrom[p] = parsed.from;
- iTo[p] = parsed.to;
+ $each(obj, function(props, i){
+ var curFrom = from[i] = {}, curTo = to[i] = {};
+ for (var p in props){
+ var parsed = Fx.CSS.prepare(this.elements[i], p, props[p]);
+ curFrom[p] = parsed.from;
+ curTo[p] = parsed.to;
}
- }
+ }, this);
return this.parent(from, to);
},
Change History
Note: See
TracTickets for help on using
tickets.