in partnership with mediatemple

Ticket #337 (closed enhancement: invalid)

Opened 10 months ago

Last modified 2 months ago

Fx.Slide - Modification to reverse direction of slide

Reported by: kenjin@… Owned by:
Type: enhancement Priority: minor
Milestone: Mootools version 1.3 Component: Core
Keywords: Cc:

Description

This is only meant to be helpful so if there is a design decision not to make the Fx.Slide work in the reverse direction I couldn't find a reference to it.

The change means an Fx.Slide can take an optional extra argument of { direction: 'normal' } or { direction: 'reverse' }, which will reverse the direction of the sliding animation.

I patched revision 743 with the changes and the diff can be found at

http://www.kenjinx.com/mootools_slide.diff

Hopefully the coding style is in keeping with the rest of mootools.

Demos can be found at

http://www.kenjinx.com/slide_example.html
&
http://www.kenjinx.com/slide_example_horizontal.html

There is a bug with the layout in the horizontal example, where the returning content from the slide in displays above the border; so if anyone can point out why that's broken that would be nice of them. I don't think that's a problem with the javascript itself so I'm all ears as to what people think that is.

Note that I don't have access to a windows box so the layout of my page may totally broken on both flavours of IE. Actually the chances are pretty high given the hackery with z-index.

Change History

Changed 8 months ago by ibolmo

  • milestone changed from Mootools version 1.2 to Mootools version 1.3

Will be considered for 1.3's Effects cleanup/enhancement.

Changed 3 months ago by kamicane

  • status changed from new to closed
  • resolution set to wontfix
  • component set to Core

Fx.Slide in reverse direction doesnt make any sense.

Its either a container with a fixed height, in which case you use top / left values, or just a height change, in which case you use Fx.Style / Fx.Tween.

Slide should only cover those situations where a margin change is required.

Changed 2 months ago by anonymous

  • status changed from closed to reopened
  • resolution deleted

I disagree - it simple makes sense to be able to do a slide in from the left or from the right, from the top or from the bottom.

Changed 2 months ago by anonymous

let me provide an example - you have a lightbox containing form. You complete the first fieldset, you might want it to slide out to the left to make room for the next fieldset sliding in from the right.

Changed 2 months ago by kamicane

  • status changed from reopened to closed
  • resolution set to invalid

Thats not a slide effect, thats a "left" effect on an absolutely positioned element.

Fx.Slide is specifically made for non-absolutely positioned elements, it makes no sense having other direction other than those that follow the page flow.

Do not reopen.

Note: See TracTickets for help on using tickets.