Changeset 1546 for trunk/Specs

Timestamp:

05/05/08 10:36:32 (2 weeks ago)

Author:

JanK

Message:

• Class events should now be used without their on prefix, i.e. addEvent('onChainComplete', fn) becomes addEvent('chainComplete'). If you want to add events in the options you need to prefix them with 'on' now ('foo' -> 'onFoo').
  

Note: This is not a breaking change.

- other minor optimizations and doc fixes

Files:

• trunk/Specs/Class/Class.Extras.js (modified) (7 diffs)

trunk/Specs/Class/Class.Extras.js

@@ -66 +66 @@
         'should add an Event to the Class': function(){
                 var myTest = new Local.EventsTest();
-                myTest.addEvent('onEvent', Local.fn);
+                myTest.addEvent('event', Local.fn);
 
                 var events = myTest.$events;
-                var myEvent = events['onEvent'];
+                var myEvent = events['event'];
                 value_of(myEvent).should_not_be(undefined);
                 value_of(myEvent.contains(Local.fn)).should_be_true();
@@ -77 +77 @@
                 var myTest = new Local.EventsTest();
                 myTest.addEvents({
-                        'onEvent1': Local.fn,
-                        'onEvent2': Local.fn
+                        'event1': Local.fn,
+                        'event2': Local.fn
                 });
 
                 var events = myTest.$events;
-                var myEvent1 = events['onEvent1'];
+                var myEvent1 = events['event1'];
                 value_of(myEvent1).should_not_be(undefined);
                 value_of(myEvent1.contains(Local.fn)).should_be_true();
 
-                var myEvent2 = events['onEvent2'];
+                var myEvent2 = events['event2'];
                 value_of(myEvent2).should_not_be(undefined);
                 value_of(myEvent2.contains(Local.fn)).should_be_true();
@@ -93 +93 @@
         'should add an internal event': function(){
                 var myTest = new Local.EventsTest();
-                myTest.addEvent('onInternal', Local.fn, true);
+                myTest.addEvent('internal', Local.fn, true);
 
                 var events = myTest.$events;
-                var myEvent = events['onInternal'];
+                var myEvent = events['internal'];
                 value_of(myEvent).should_not_be(undefined);
                 value_of(myEvent.contains(Local.fn)).should_be_true();
@@ -105 +105 @@
                 var myTest = new Local.EventsTest();
                 var fn = function(){ return true; };
-                myTest.addEvent('onEvent', Local.fn);
-                myTest.addEvent('onEvent', fn);
-                myTest.removeEvent('onEvent', Local.fn);
+                myTest.addEvent('event', Local.fn);
+                myTest.addEvent('event', fn);
+                myTest.removeEvent('event', Local.fn);
 
                 var events = myTest.$events;
-                var myEvent = events['onEvent'];
+                var myEvent = events['event'];
                 value_of(myEvent).should_not_be(undefined);
                 value_of(myEvent.contains(fn)).should_be_true();
@@ -118 +118 @@
                 var myTest = new Local.EventsTest();
                 var fn = function(){ return true; };
-                myTest.addEvent('onEvent', Local.fn);
-                myTest.addEvent('onEvent', fn);
-                myTest.removeEvents('onEvent');
+                myTest.addEvent('event', Local.fn);
+                myTest.addEvent('event', fn);
+                myTest.removeEvents('event');
 
                 var events = myTest.$events;
-                value_of(events['onEvent'].length).should_be(0);
+                value_of(events['event'].length).should_be(0);
         },
 
@@ -129 +129 @@
                 var myTest = new Local.EventsTest();
                 var fn = function(){ return true; };
-                myTest.addEvent('onEvent1', Local.fn);
-                myTest.addEvent('onEvent2', fn);
+                myTest.addEvent('event1', Local.fn);
+                myTest.addEvent('event2', fn);
                 myTest.removeEvents();
 
                 var events = myTest.$events;
-                value_of(events['onEvent1'].length).should_be(0);
-                value_of(events['onEvent2'].length).should_be(0);
+                value_of(events['event1'].length).should_be(0);
+                value_of(events['event2'].length).should_be(0);
         }
 
@@ -187 +187 @@
                 var events = myTest.$events;
                 value_of(events).should_not_be(undefined);
-                value_of(events['onEvent1'].length).should_be(1);
-                value_of(events['onEvent2'].length).should_be(1);
-                value_of(events['onEvent3'].length).should_be(1);
+                value_of(events['event1'].length).should_be(1);
+                value_of(events['event2'].length).should_be(1);
+                value_of(events['event3'].length).should_be(1);
         }